Diandra1128 / Colmar

0 stars 0 forks source link

HTML #2

Open ulisigi opened 5 years ago

ulisigi commented 5 years ago

Your HTML implementation enables proper use of media queries in 1-3 sections, and your HTML structure reflects the grouping and flow of content in the web browser. Much as it was needed to structure the HTML of the <header> to enable the switch between text and icons at different screen sizes, so also is it likely needed in order to enable the changes in the Keep Practicing and Start Learning sections.

Good use of some comments in your code for organization. I recommend using more descriptive alt attributes for your image, as this is what will be displayed if the image can't be viewed or read if the site visitor is using a screen reader. Also on the topic of accessibility, I recommend utilizing addition semantic elements such as <section> or <article>. Semantic elements will also improve the readability of your code and the SEO (search engine optimization) of your page.

Here's a reference for semantic elements: https://developer.mozilla.org/en/docs/Web/HTML/Element

Here's an article about semantic elements and accessibility: https://24ways.org/2017/accessibility-through-semantic-html/