search

Diaoul / arduino-ESP8266

An Arduino library to manage the ESP8266.
MIT License
68 stars 46 forks source link

Doesn't compile with Arduino 1.0.6 #1

Closed lasselukkari closed 9 years ago

lasselukkari commented 9 years ago

ESP8266.cpp:647: error: invalid conversion from 'uint8t' to 'char_'

Changed buffer type and added missing right curly bracket.

Diaoul commented 9 years ago

Actually the goal is to easily implement the client interface so it's uint8_t, I find this a little weird too, char is far more common for read methods.

It's weird you have this compile error, did you pass char* instead of uint8_t* ? Ideally we should return the same type as serial->readBytes() and other serial read methods which is char*...

lasselukkari commented 9 years ago

And about the char . The Stream interface in Resources/Java/hardware/arduino/cores/arduino/Stream.h defines it as "size_t readBytes( char buffer, size_t length);"

Diaoul commented 9 years ago

Yes, let's do this. Please also rename the arguments to match the Stream.h way.

Make a dedicated PR for this as I won't merge the beginSend stuff now.

lasselukkari commented 9 years ago

I removed the accidental commit and renamed the arguments.

Thanks for the good work.

madprogrammi commented 9 years ago

Confirmed, Arduino 1.0.6 Arch Linux x86_64. :)