"test5" movie metadata mismatches

ptrcnull commented 3 months ago

( not yet sure what causes it, could be bumped dependencies ) in 2.2.0, test_refine_video_metadata started failing on video_codec and release_group:

_________________________________ test_refine_video_metadata __________________________________

    def test_refine_video_metadata(mkv):
        scanned_video = scan_video(mkv['test5'])
        refine(scanned_video, episode_refiners=('metadata',), movie_refiners=('metadata',))
        assert type(scanned_video) is Movie
        assert scanned_video.name == mkv['test5']
        assert scanned_video.source is None
        assert scanned_video.release_group is None
        assert scanned_video.resolution is None
>       assert scanned_video.video_codec == 'H.264'
E       AssertionError: assert None == 'H.264'
E        +  where None = <Movie [test5]>.video_codec

tests/test_core.py:256: AssertionError

_________________________________ test_refine_video_metadata __________________________________

    def test_refine_video_metadata(mkv):
        scanned_video = scan_video(mkv['test5'])
        refine(scanned_video, episode_refiners=('metadata',), movie_refiners=('metadata',))
        assert type(scanned_video) is Movie
        assert scanned_video.name == mkv['test5']
        assert scanned_video.source is None
>       assert scanned_video.release_group is None
E       AssertionError: assert 'subliminal' is None
E        +  where 'subliminal' = <Movie [2]>.release_group

tests/test_core.py:254: AssertionError

getzze commented 3 months ago

It looks like enzyme was not updated to version 0.5.0. Earlier versions don't work with python 3.12 if you don't have setuptools manually installed. See #1126

ptrcnull commented 3 months ago

i can reproduce the latter with enzyme 0.5.1, and setuptools installed as well

getzze commented 3 months ago

Mmm, that's strange. The automatic tests are passing and I also cannot reproduce in local.

On 25 June 2024 16:35:38 GMT+01:00, Patrycja @.***> wrote:

the latter happens with enzyme 0.5.1, and setuptools installed as well

-- Reply to this email directly or view it on GitHub: https://github.com/Diaoul/subliminal/issues/1135#issuecomment-2189279720 You are receiving this because you commented.

Message ID: @.***>

getzze commented 2 months ago

So it is a feature of guessit to look for parent folder to guess the name and other stuff. Because the filename test5.mkv is not indicative enough, it looks for the parents. In case of #1157, the subliminal-2.2.1 parent folder was parsed as release_group and name. I will remove this assert in #1154, so it should be solved.

Diaoul / subliminal

"test5" movie metadata mismatches #1135