search

Diaoul / subliminal

Subtitles, faster than your thoughts
http://subliminal.readthedocs.org
MIT License
2.42k stars 312 forks source link

Remove requirement for episode number when guessing #1165

Open ptrcnull opened 3 months ago

ptrcnull commented 3 months ago

with some types of episodes, such as extras, the episode number will be missing, but the subtitle download succeeds with the check removed

github-actions[bot] commented 3 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  subliminal
  video.py
Project Total  

This report was generated by python-coverage-comment-action

ptrcnull commented 3 months ago

ah, actually, sometimes it just pulls the first episode of the season...

getzze commented 3 months ago

Fixes #692

And it would be great if this PR could also tackle #678

They don't look easy to fix though...

getzze commented 2 months ago

Are you still working on this? I just realized it's a duplicate of: https://github.com/Diaoul/subliminal/pull/702

ptrcnull commented 2 months ago

to be fair, the other MR is flawed in the same way as mine is

ptrcnull commented 2 months ago

but to answer your question, i forgot about it, but at some point i'd like to either fix it myself, or see it fixed ^^