search

Diaoul / subliminal

Subtitles, faster than your thoughts
http://subliminal.readthedocs.org
MIT License
2.42k stars 312 forks source link

Napisy24 provider #742

Open MoshiMoshi0 opened 7 years ago

MoshiMoshi0 commented 7 years ago

Any chance to add napisy24.pl as a provider? There is no public API, but qnapi project has a working solution.

edit: API can be found here.

darzur commented 7 years ago

KODI have also working Napisy24 addon so it should be doable.

MoshiMoshi0 commented 7 years ago

I have implemented the provider but it always downloads the subtitles in MPL2 format. but its not always in srt format. I will not create a pull request until I reverse engineer the API and find a way to download them in srt, or until subliminal has implemented subtitle type conversion.

@Diaoul Any updates on your subtitle type converter project? Will it also support MPL2? fyi pycaption project has been updated to py3 and is still somewhat maintained.

Diaoul commented 7 years ago

I've made progress converting the subtitle to objects, it works great for srt so far. I took the generator approach so it's more lightweight than pycaption. I'm working on microdvd format but didn't hear about mpl2 so far. It is possible to create a parser for it though. I hoped webvtt would take over as standardized subtitle format but it hasn't happend yet.

MoshiMoshi0 commented 7 years ago

MPL2 is very simple format. Any ETA on when you might push alpha version to github (if thats the plan)? I could write the MPL2 parser.

Btw, how will it handle subtitle with mixed tags? For example, MPL2 is simple format but people often include MicroDVD tags (italics, color etc). This can also happen when people badly convert from for example MicroDVD to srt. Then the uploaded subtitle is in srt format but has MicroDVD style tags. Would be nice if it could fix mixed tags.

Diaoul commented 7 years ago

It's been a while I haven't the time to work on it but nested styles works, what doesn't is invalid style such as <i>italic<b>italic+bold</i></b>. I'll make a branch and push what I have so far, which isn't much sadly...

MoshiMoshi0 commented 7 years ago

@Diaoul any updates on that branch? Im thinking about maybe trying to create my own converter.