search

Diaoul / subliminal

Subtitles, faster than your thoughts
http://subliminal.readthedocs.org
MIT License
2.42k stars 312 forks source link

imdb and tvdb ID data #845

Closed shlomiLan closed 5 years ago

shlomiLan commented 6 years ago

video = Video.fromname(episode.name) when I use this function I always get None for tvdb_id, imdb_id and series_imdb_id. In the code, it looks like this information should get from guessit, but it has no support for this information, am I missing anything? it there a flag or a function call that I can use to add this info?

fernandog commented 6 years ago

@shlomiLan AFAIK it should come from the refiner. The OMDB requires an API now so Subliminal can't use for now

shlomiLan commented 6 years ago

@fernandog the refine is only been used when running in CLI mode, is that right?

fernandog commented 6 years ago

It's runs in commans line too. You should see a traceback that wasn't able to connect to omdb

shlomiLan commented 6 years ago

When I look at the source code the only places where the tvdb refine function is been called is in the test_tvdb.py. Can I try and add it to video.py inside the fromguess function of the Episode class. I think it should do the job.

shlomiLan commented 6 years ago

I added TVDB and IMDB ID's in commit: 85e2f5f

ratoaq2 commented 5 years ago

refiners are registered as extensions like the providers and they always run in the cli The difference is that in the API, you decide which methods you want to call, including refine