search

DiasPHPora / wp-to-diaspora

Automatically share WordPress posts on diaspora*
https://wordpress.org/plugins/wp-to-diaspora/
GNU General Public License v2.0
14 stars 1 forks source link

Pod login issue #174

Closed davehill47 closed 1 year ago

davehill47 commented 2 years ago

WP to Diaspora* is a great plug-in that I use as a key part of mirroring one of my WP blogs to a diaspora site (where, ironically, it gets much better engagement than on WP).

About a month ago, the plugin stopped working on my diasp.org pod site with a login error ("Login failed. Check your login details"), even though the userid/password works fine for direct logins (and I even changed the password and the symptoms remained). The owner/support person for the pod says:

"That is right when i updated the pod. I know the update forced some security bugs to be patched, so I'd guess it was that."

I know this plugin is in a bit of limbo at the moment, but is anyone available to fix it? I'd hate to see it permanently failing.

noplanman commented 2 years ago

Hi @davehill47 sorry to hear that it's not working for you any more.

From your message it looks like the login mechanism we used in this plugin doesn't work any more for newer version of diaspora. Hmm, that's really unfortunate, as I don't really have the time now to look into this to write a fix.

If you're up for digging into the code and providing a patch, I'd be happy to review and get it merged though!

davehill47 commented 2 years ago

Alas, my programming days were too many decades ago, even if I knew anything about current diaspora* logins. A shame, as this has been a fantastic resource.

Thanks for the quick reply, Armando.

*** Dave

On Thu, Sep 1, 2022 at 3:42 PM Armando Lüscher @.***> wrote:

Hi @davehill47 https://github.com/davehill47 sorry to hear that it's not working for you any more.

From your message it looks like the login mechanism we used in this plugin doesn't work any more for newer version of diaspora. Hmm, that's really unfortunate, as I don't really have the time now to look into this to write a fix.

If you're up for digging into the code and providing a patch, I'd be happy to review and get it merged though!

— Reply to this email directly, view it on GitHub https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1234811805, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHYVS6USQ7JCYRQHAZB73V4EPKXANCNFSM6AAAAAAQA6PDIQ . You are receiving this because you were mentioned.[image: Web Bug from https://github.com/notifications/beacon/AALHYVUTTBEWKM7674NEQWDV4EPKXA5CNFSM6AAAAAAQA6PDISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSJTG5Z2.gif]Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1234811805", "url": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1234811805", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": " https://github.com" } } ]

kampfflunder commented 2 years ago

I'm in the same boat :-(

noplanman commented 2 years ago

I've done a quick test with Guzzle (a dedicated HTTP request client) and it works perfectly with the latest version of d*.

The issue with the current implementation this plugin, is that the cookie to remember the login seems to get lost, or rather, it has no content. Not sure why this is happening though :thinking: It appears that some security layer in d* is being triggered, clearing the cookie prematurely.

I'll investigate further and hopefully release a fix soon.

Edit: Looks like the CSRF token is handled somewhat differently since 0.7.18.0, most likely due to a version bump of libraries used.

davehill47 commented 2 years ago

That is awesome, thanks, Armando!

*** Dave

On Mon, Sep 12, 2022 at 3:22 PM Armando Lüscher @.***> wrote:

I've done a quick test with Guzzle (a dedicated HTTP request client) and it works perfectly with the latest version of d*.

The issue with the current implementation this plugin, is that the cookie to remember the login seems to get lost, or rather, it has no content. Not sure why this is happening though 🤔 It appears that some security layer in d* is being triggered, clearing the cookie prematurely.

I'll investigate further and hopefully release a fix soon.

— Reply to this email directly, view it on GitHub https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1244498069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHYVWUJUVFQ72KBXUGGBTV56NHVANCNFSM6AAAAAAQA6PDIQ . You are receiving this because you were mentioned.[image: Web Bug from https://github.com/notifications/beacon/AALHYVSWPD4NASK7QZ7UYRTV56NHVA5CNFSM6AAAAAAQA6PDISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSKFWEJK.gif]Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1244498069", "url": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1244498069", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": " https://github.com" } } ]

noplanman commented 2 years ago

I hope you guys are on PHP8, as the next release is quite a re-write and minimum PHP version will be bumped to PHP8.

Stay tuned...

davehill47 commented 2 years ago

I think that should be fine for me. Thanks!

On Sat, Sep 17, 2022 at 7:46 PM Armando Lüscher @.***> wrote:

I hope you guys are on PHP8, as the next release is quite a re-write and minimum PHP version will be bumped to PHP8.

Stay tuned...

— Reply to this email directly, view it on GitHub https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1250172487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHYVVOZYSZG5XGCCOFHPLV6ZYA7ANCNFSM6AAAAAAQA6PDIQ . You are receiving this because you were mentioned.[image: Web Bug from https://github.com/notifications/beacon/AALHYVWBAJZFVLWM5XGM7UTV6ZYA7A5CNFSM6AAAAAAQA6PDISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSKQQPEO.gif]Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1250172487", "url": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1250172487", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": " https://github.com" } } ]

noplanman commented 1 year ago

@kampfflunder @davehill47

Oh my, how has a whole year passed already since I last wrote here?!! :scream:

I've had another report of a pod connection not working, so will try to get a new release out for you guys.

Sorry for the epic delay...

davehill47 commented 1 year ago

Thanks, Armando.

*** Dave

On Mon, Aug 28, 2023 at 3:21 PM Armando Lüscher @.***> wrote:

@kampfflunder https://github.com/kampfflunder @davehill47 https://github.com/davehill47

Oh my, how has a whole year passed already since I last wrote here?!! 😱

I've had another report of a pod connection not working, so will try to get a new release out for you guys.

Sorry for the epic delay...

— Reply to this email directly, view it on GitHub https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1696429579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHYVQ54LOXJMH3BWZAC43XXUDVXANCNFSM6AAAAAAQA6PDIQ . You are receiving this because you were mentioned.[image: Web Bug from https://github.com/notifications/beacon/AALHYVX6BHEBQ7IYBVVY4ODXXUDVXA5CNFSM6AAAAAAQA6PDISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFDV3AW.gif]Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1696429579", "url": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1696429579", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": " https://github.com" } } ]

noplanman commented 1 year ago

@davehill47 @kampfflunder

I'm 99% there :tada:

Could you please try this attacked version and let me know if it works for you. When I get a positive response I'll officially release it.

wp-to-diaspora-3.5.0.zip

  1. WP Admin > Plugins > Add New
  2. Select the zip file you just downloaded
  3. Choose to "Replace current with uploaded"
  4. Try it out!
kampfflunder commented 1 year ago

Well, it works again! YESSS! Thank you so much!

davehill47 commented 1 year ago

Sorry, apparently I still have some unexpected problem in upgrading to PHP

  1. Will be working on that, but very glad to hear the plugin is operational!

*** Dave

On Sat, Sep 9, 2023 at 10:14 AM Armando Lüscher @.***> wrote:

@davehill47 https://github.com/davehill47 @kampfflunder https://github.com/kampfflunder

I'm 99% there 🎉

Could you please try this attacked version and let me know if it works for you. When I get a positive response I'll officially release it.

wp-to-diaspora-3.5.0.zip https://github.com/DiasPHPora/wp-to-diaspora/files/12566214/wp-to-diaspora-3.5.0.zip

  1. WP Admin > Plugins > Add New
  2. Select the zip file you just downloaded
  3. Choose to "Replace current with uploaded"
  4. Try it out!

— Reply to this email directly, view it on GitHub https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1712546150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHYVWLUOJ6FCPNH5ZFROTXZSIVJANCNFSM6AAAAAAQA6PDIQ . You are receiving this because you were mentioned.[image: Web Bug from https://github.com/notifications/beacon/AALHYVS7YMIQSJZ2WF775CLXZSIVJA5CNFSM6AAAAAAQA6PDISWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTGCNQWM.gif]Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1712546150", "url": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#issuecomment-1712546150", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": " https://github.com" } } ]

noplanman commented 1 year ago

Alrighty then, version 4.0.0 has been released now, hope it works for you all! :crossed_fingers:

davehill47 commented 1 year ago

Thanks!

On Fri, Sep 29, 2023 at 9:01 AM Armando Lüscher @.***> wrote:

Closed #174 https://github.com/DiasPHPora/wp-to-diaspora/issues/174 as completed.

— Reply to this email directly, view it on GitHub https://github.com/DiasPHPora/wp-to-diaspora/issues/174#event-10512459835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHYVSDX2YK4ANUW6I4G6DX43PC5ANCNFSM6AAAAAAQA6PDIQ . You are receiving this because you were mentioned.[image: Web Bug from https://github.com/notifications/beacon/AALHYVX4G3WBFJOTFLAZ4ZDX43PC5A5CNFSM6AAAAAAQA6PDISWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAE4UXNA5Q.gif]Message ID: @. com> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#event-10512459835", "url": " https://github.com/DiasPHPora/wp-to-diaspora/issues/174#event-10512459835", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": " https://github.com" } } ]