search

Diaz335 / plntpth8300_final_project

0 stars 0 forks source link

Updated Proposal #2

Open Diaz335 opened 3 years ago

Diaz335 commented 3 years ago

Hey @jelmerp I updated my proposal. I was uncertain of the direction I was going to take with the haplotype analysis but I was able to find this paper https://www.frontiersin.org/articles/10.3389/fgene.2020.00282/full which is similar to the direction I want to take with my dissertation chapter. Basically, I am wanting to run a GWAS using SNPs and also GWAS using haplotypes.

jelmerp commented 3 years ago

Hi Josue,

Thanks for the update, and that looks great! 10/10 points for the proposal.

But you currently have 6 commits named "Update proposal.md" -- try to be more descriptive! For instance, your last 3 commits are 2 with only minor cosmetic changes and 1 with the bulk of the actual update, but I had to look at all the diffs to find that out and see what you changed. Note that I will take Git commit messages into account when grading future updates to the project.

Diaz335 commented 3 years ago

Hello Jelmer,

I've continued to have issues with the commits this time I believe it was because I pushed commits from Github (used atom and github desktop) and then I failed to pull when I was using vis code. I was then having issues pushing from vis code and ended up just trying anything to get it to push while failing to add descriptions( I had become a bit frustrated and was just trying to make it work at that point).

Josue Diaz Graduate Research Fellow | Dr. Leah McHale Lab Center for Applied Plant SciencesTranslational Plant Sciences Graduate Program

326 Kottman Hall, 2021 Coffey Road, Columbus, OH 43212

From: Jelmer W. Poelstra @.> Sent: Tuesday, March 30, 2021 12:57 PM To: Diaz335/plntpth8300_final_project @.> Cc: Josue Diaz @.>; Author @.> Subject: Re: [Diaz335/plntpth8300_final_project] Updated Proposal (#2)

Hi Josue,

Thanks for the update, and that looks great! 10/10 points for the proposal.

But you currently have 6 commits named "Update proposal.md" -- try to be more descriptive! For instance, your last 3 commits are 2 with only minor cosmetic changes and 1 with the bulk of the actual update, but I had to look at all the diffs to find that out and see what you changed. Note that I will take Git commit messages into account when grading future updates to the project.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/Diaz335/plntpth8300_final_project/issues/2*issuecomment-810422704__;Iw!!KGKeukY!k13TPnfaNJCoWGXkikQdqFG_xQJvL2k4Vgibmuc3kpD2cCpv9HaHQm0vyV0yW-AxNQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQYIGL72TXHS6ZUOXXVPILTTGH7JLANCNFSM42BANQKQ__;!!KGKeukY!k13TPnfaNJCoWGXkikQdqFG_xQJvL2k4Vgibmuc3kpD2cCpv9HaHQm0vyV3Dz-aHIg$.