search

Dica-Developer / generator-node-webkit

Yeoman generator for nwjs applications
MIT License
282 stars 40 forks source link

Notifications API is not working in OSX #85

Open acketon opened 8 years ago

acketon commented 8 years ago

Notifications don't display when called via javascript on OSX Yosemite 10.10.5

If I load my app files into the v0.12.3 64bit release from NW manually they work, but the same files will not trigger notifications when using this generator to build a distribution of the app.

I recreated it as well by creating a new generator project with the notifications sample project installed. Notifications in that built sample application do not show. (the built in ones, node-notifier and nw-notify both show)

acketon commented 8 years ago

I dug into it a bit more and the info.plist in by dist folder .app has about 15 entries while the source version in the nwjs folder has 22 entries. If I swap the dist folder info.plist file for the one from the nwjs folder then notifications work again in the app.

mschaaf commented 8 years ago

@acketon thanks for the investigation. Could you please provide us a diff so that we are able to build a fix? Thanks.

acketon commented 8 years ago

I don't have a fix, I just disabled the grunt task that modifies the .plist file for now. I'm not sure what is the root cause.

mschaaf commented 8 years ago

But could you please diff the plist that works for you and the one generated by the generator. If the plist is the reason then this could show us what the generator misses.