Open AshwinKul28 opened 1 week ago
@AshwinKul28, can I pick this up?
Hey @anchalsinghrajput thanks! Go for it. 🚀
HI @anchalsinghrajput , I hope you are doing well. Do you happen to have any updates on this? If you've any doubts please let us know on the discord.
@AshwinKul28 @anchalsinghrajput if you are currently occupied with something else, I can pick this up.
Hi @AshwinKul28 @vpsinghg, I am new to go, i am still working on it, will give the update once i complete it.
Hi @AshwinKul28 , can you please reassign this issue to this Git profile.
Done @anchalsingh25 I see you have opened a PR, please attach this issue to the PR. Thanks
This issue tracks the migration of the mentioned commands - ('HSET', 'HGET', 'HSETNX', 'HDEL') to make them compatible across the three protocols supported by the Dice database: RESP, HTTP, and WebSocket. DiceDB now supports more than one protocols (Resp/http/websocket). We don't want eval operation of each command to be strictly bound with any of the protocols. Currently eval function return statements of each command is bounded to the RESP protocol.
The migration is required because:
The goal is to make the command logic protocol-independent, allowing all three protocols to call the same core functionality seamlessly.
Requirements
[Command Name]
to be generic.Migration Steps
Analyze Current Implementation
Refactor Return Logic
evalXXX(args []string, store *dstore.Store) *EvalResponse
under the file/internal/eval/store_eval.go
/errors/migrated_errors.go
file/internal/clientio/resp.go
file as RespType variablesCommand/Worker specific Changes
IsMigrated
flag to true in the commands information under/internal/eval/commands.go
file.NewEval
parameter in the same command structure./internal/eval/eval.go
file./internal/worker/CommandsMeta
map and make it's type asSingleShard
Update Unit Tests
Integration Tests
Checklist
Additional Notes
If there are any questions or concerns about this migration, please mention them here.
Related Issues/PRs