search

DiceDB / dice

DiceDB is a redis-compliant, in-memory, real-time, and reactive database optimized for modern hardware and for building and scaling truly real-time applications.
https://dicedb.io/
Other
6.69k stars 1.06k forks source link

Inconsistent `LPOP`: Support for `COUNT` parameter #1057

Open JyotinderSingh opened 3 weeks ago

JyotinderSingh commented 3 weeks ago

Steps to reproduce

LPOP does not support the COUNT parameter.

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

JyotinderSingh commented 3 weeks ago

@Kripu77 should I assign this to you?

Devashish08 commented 3 weeks ago

@JyotinderSingh can you assign this to me this will be my first issue so i can try to work on it

Kripu77 commented 3 weeks ago

Hi, @JyotinderSingh yes please assign this to me. Thank you

JyotinderSingh commented 3 weeks ago

@JyotinderSingh can you assign this to me this will be my first issue so i can try to work on it

Hi @Devashish08, since this issue was reported by @Kripu77 and they wanted to take it up, I've assigned it accordingly. There are more open issues on the repo, please take a look!

arpitbbhayani commented 1 week ago

Hello @Kripu77,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Kripu77 commented 1 week ago

Hello @Kripu77,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Hi @arpitbbhayani

I have the updates ready, I just haven't got my time to work on the integration tests.

Please allow me some more time and I'll raise a PR.

Thanks