search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.88k stars 1.1k forks source link

Add support for command `ZRANK` #1126

Closed JyotinderSingh closed 1 month ago

JyotinderSingh commented 1 month ago

Add support for the ZRANK command in DiceDB similar to the ZRANK command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

SyedMa3 commented 1 month ago

Can I work on this?

JyotinderSingh commented 1 month ago

Can I work on this?

Assigned, good to see you back @SyedMa3!

SyedMa3 commented 1 month ago

Can I work on this?

Assigned, good to see you back @SyedMa3!

Glad to be back! Created a PR. Not 100% sure if I have covered all bases since the code has changed a lot from the last time! 😮