search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.88k stars 1.1k forks source link

Add support for command `ZCARD` #1129

Closed JyotinderSingh closed 1 month ago

JyotinderSingh commented 1 month ago

Add support for the ZCARD command in DiceDB similar to the ZCARD command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

swarajrb7 commented 1 month ago

@JyotinderSingh can I pick this issue?

JyotinderSingh commented 1 month ago

@JyotinderSingh can I pick this issue?

Assigned.

c-harish commented 1 month ago

Hi @JyotinderSingh. Since @swarajrb7 is working on LATENCY, can I take this one?

JyotinderSingh commented 1 month ago

Hi @JyotinderSingh. Since @swarajrb7 is working on LATENCY, can I take this one?

Sounds good.

arpitbbhayani commented 1 month ago

Hello @c-harish,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

c-harish commented 1 month ago

Hello @c-harish,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Hi @arpitbbhayani. Will raise PR tonight. Thanks