search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.88k stars 1.1k forks source link

Add support for `PFCOUNT.WATCH` command #1133

Closed JyotinderSingh closed 2 weeks ago

JyotinderSingh commented 1 month ago

Add support for reactive queries on the existing PFCOUNT command by introducing PFCOUNT.WATCH.

This command should send push-responses to subscribed clients whenever the data inside the respective hash set changes.

As a part of this feature, you are also required to add support for the same to the dicedb-go SDK inside the watch_command.go file.

Reference

  1. You may refer to #1047 to understand the changes required to support this command.

  2. 924 provides more background on the feature's underlying implementation (but may not be directly relevant to this issue)

Testing

  1. Ensure integration tests are added, you can refer to existing .WATCH integration tests.
  2. Integration tests should include both resp tests and SDK tests.
iamskp11 commented 1 month ago

Would like to work on this @JyotinderSingh .pls assign

JyotinderSingh commented 1 month ago

Would like to work on this @JyotinderSingh .pls assign

Assigned.

arpitbbhayani commented 1 month ago

Hello @iamskp11,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

iamskp11 commented 1 month ago

Just an update : currently testing the implementation. Will be raising PR by tomorrow EOD

reapedjuggler commented 3 weeks ago

Hi @iamskp11 Are you still working on this issue, I see its been some time, I can take this up if its available from your end, otherwise I can also pick up #1253 if you want to work on this one. Please let me know, cheers 🚀 // @JyotinderSingh

iamskp11 commented 2 weeks ago

Hi @iamskp11 Are you still working on this issue, I see its been some time, I can take this up if its available from your end, otherwise I can also pick up #1253 if you want to work on this one. Please let me know, cheers 🚀 // @JyotinderSingh

Will push the commit PR today EOD.