Migration/json.commands - Githubissues

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.86k stars 1.09k forks source link

Migration/json.commands #1189

Closed vpsinghg closed 2 weeks ago

vpsinghg commented 1 month ago

This PR includes changes for migration of JSON.DEL, JSON.FORGET, JSON.TOGGLE, JSON,NUMINCRBY and JSON.NUMMULTBY command to new Eval method. This resolves issue #1029

Also introduces fix for oom err in resp protocol integration test on lower spec machines.

Improved Integration Test format.

Tasks Checklist

[x] Migrated the evalXXX function with the latest definition
[x] Update or add unit tests for the new implementation.
[x] All unit tests pass successfully.
[x] Ensure all integration tests pass successfully.

vpsinghg commented 1 month ago

@AshwinKul28 Please review and let me know if any changes required. Thank you

vpsinghg commented 3 weeks ago

@AshwinKul28 is there any feedback ? Hope you got to review this PR. Thanks

JyotinderSingh commented 3 weeks ago

@AshwinKul28 is there any feedback ? Hope you got to review this PR. Thanks

Hi @vpsinghg! Thanks for these changes. Since festive season has begun the reviews may take a little more time than usual, please bear with us!

vpsinghg commented 3 weeks ago

@JyotinderSingh In the meantime can you please assign me some pending issues?

apoorvyadav1111 commented 2 weeks ago

Hi @vpsinghg , please rebase your pr. Thanks, Apoorv

vpsinghg commented 2 weeks ago

@apoorvyadav1111 There are lot of changes after my changes and lot of conflicts. I will refactor and reraise new PR by tomorrow night.