#869 Added per-worker id generation logic

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.86k stars 1.09k forks source link

#869 Added per-worker id generation logic #1213

Open manishrw opened 4 weeks ago

manishrw commented 4 weeks ago

Fixes #869

Implemented a lock-free, per-worker ID generation method to enhance concurrency performance.
Removed mutex locks, using atomic operations for thread-safe ID generation.
Integrated unique worker IDs into the ID format for distinctiveness. Reserved 4 bits for worker ID.
Updated ExpandID to align with the new generation logic.
Added tests and benchmarks to ensure correctness and measure performance improvements for NextID func.

manishrw commented 4 weeks ago

@lucifercr07 @JyotinderSingh I've implemented the id generation logic per worker and lock free. Please review it. Issue: #869

manishrw commented 3 weeks ago

@lucifercr07 @JyotinderSingh Reminder to review this PR!

manishrw commented 2 weeks ago

@lucifercr07 has the review been done?

JyotinderSingh commented 2 weeks ago

@lucifercr07 has the review been done?

Apologies for the delay in reviews for this PR @manishrw. We'll get to this asap.

arpitbbhayani commented 1 week ago

@manishrw Hello Manish thanks a ton for the PR. The changes are good, but given our uncertainty about txn support we would like to hold back merging this PR.

Once we add txn support, we will have a clear idea of implementation challenges and we will be in a better position to merge this. We are just deferring the merge, until we form the clarity.

Thanks a ton for raising the PR.