#1021 #785 #819 Command migration for HSET, HMSET, HGET, HMGET, HSETNX, HDEL - Githubissues

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.83k stars 1.08k forks source link

#1021 #785 #819 Command migration for HSET, HMSET, HGET, HMGET, HSETNX, HDEL #1219

Closed anchalsingh25 closed 2 weeks ago

anchalsingh25 commented 3 weeks ago

PR for #1021, #785, #819 Checklist:

[x] Migrated the evalXXX function with the latest definition
[x] Update or add unit tests for the new implementation.
[x] All unit tests pass successfully.
[ ] Ensure all integration tests pass successfully.
[x] Add Integration tests for the respective commands under the RESP integration tests directory
[x] Move Integration tests for the respective commands under the RESP integration tests directory from Async directory
[x] Please validate that the documentation for the respective commands is up to date. If not then consider adding them.

apoorvyadav1111 commented 2 weeks ago

Hi @anchalsingh25 , looks like some of the unit tests are failing and they could be due to new method of returning error. Please use the following commands to ensure PR gets checks pass. unit tests:

make unittest

integration tests:

make test

linter:

golangcli-lint run

As you know, we would like to close this soon, please reach out to us on the community if you face any issue.

Thanks