search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.83k stars 1.08k forks source link

#1193: Add type check for string compatibility in evalAPPEND function #1237

Closed shashi-sah2003 closed 1 week ago

shashi-sah2003 commented 2 weeks ago

fixes #1193 added type check for string compatibility as it was giving panic issue with append is used after ZADD command

shashi-sah2003 commented 2 weeks ago

@apoorvyadav1111 pls look at this PR and review it and also let me know if there is anything more I need to check with append command

EDIT: I'm working on why this is failing on tests

apoorvyadav1111 commented 1 week ago

Hi @shashi-sah2003 , any update on failing tests? Please reach out to use on discord if you need any clarifications.

shashi-sah2003 commented 1 week ago

Hi @shashi-sah2003 , any update on failing tests? Please reach out to use on discord if you need any clarifications.

hey @apoorvyadav1111 apologies for delay. I have added the logic for append command such that it is compatible with sortedset. pls let me know if there are any more changes you want me to do. thanks