search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.83k stars 1.08k forks source link

#207 Feature: get in set #1238

Closed apoorvyadav1111 closed 1 week ago

apoorvyadav1111 commented 2 weeks ago

Hi team,

Fixes: #207

Added support for GET option in SET.

JyotinderSingh commented 2 weeks ago

There seems to be a small test failure. Probably unrelated to your changes. Should be fixed with a rebase hopefully (or you can do it manually)

apoorvyadav1111 commented 2 weeks ago

Thanks @JyotinderSingh, I just rebased + fixed the issue, and its passing unit tests now.

apoorvyadav1111 commented 2 weeks ago

Hi @tejasa97 , thanks for your review , I ll be addressing them soon.

apoorvyadav1111 commented 1 week ago

Hi @JyotinderSingh , @tejasa97, have addressed the comments, please review. Thanks