Closed vinitparekh17 closed 5 days ago
Although it is work in progress, I am open for suggestions and feedback from the community. @JyotinderSingh @lucifercr07 @soumya-codes @arpitbbhayani @apoorvyadav1111
pending changes,
Thanks for working on this @vinitparekh17. The overall changes seem to be going in the correct direction!
@JyotinderSingh, @lucifercr07 review plz
[generated by github copilot]
This pull request introduces a new configuration parser, updates configuration files, and modifies test setup and dependencies. The most important changes include the addition of a new
ConfigParser
inconfig/parser.go
, updates to configuration files, and adjustments in test setup and dependency management.Configuration Management:
config/parser.go
: Added a newConfigParser
to handle parsing configuration files and unmarshalling configuration values into structs. This parser supports reading from files, stdin, and setting default values.Configuration Files:
dice.conf
: Added a new configuration file for Dicedb with various settings including server, HTTP, WebSocket, performance, memory, persistence, logging, authentication, and network configurations.dice.toml
: Removed the old TOML configuration file that included similar settings to the newdice.conf
file.Dependency Management:
go.mod
: Removed several indirect dependencies and addedgithub.com/kr/pretty
as a new indirect dependency. [1] [2]Test Setup Adjustments:
integration_tests/commands/http/setup.go
: Updated the HTTP server setup to use the new configuration structure.integration_tests/commands/websocket/setup.go
: Updated the WebSocket server setup to use the new configuration structure.Test Improvements:
integration_tests/commands/websocket/json_test.go
: Added missing error assertions in theTestJsonARRTRIM
andTestJsonARRINSERT
tests. [1] [2]integration_tests/config/config_test.go
: Commented out old test cases and added a placeholder for new tests to be implemented.