search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.83k stars 1.08k forks source link

Add support for command `GEOPOS` #1249

Open arpitbbhayani opened 2 weeks ago

arpitbbhayani commented 2 weeks ago

Add support for the GEOPOS command in DiceDB similar to the GEOPOS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

helios2003 commented 2 weeks ago

Hi, can I take this issue up?

apoorvyadav1111 commented 1 week ago

Hi @helios2003 , Assigned. Thanks for contributing to DiceDB.

lucifercr07 commented 23 hours ago

@helios2003 any updates on this?

helios2003 commented 22 hours ago

Hi, @lucifercr07 sorry for the delay. I had my exams in between, so I will make a PR by tomorrow.