New fixes in the CI - Githubissues

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.83k stars 1.08k forks source link

Closed kitarp29 closed 5 days ago

kitarp29 commented 1 week ago

As discussed here: https://github.com/DiceDB/dice/pull/1116#issuecomment-2455390991 I am opening a new issue for these two changes in the CI

Conditional triggering of linting and Testing pipeline when changes are done to only .go file (This can change if the project ever changes/includes anything other than go)
Caching setup for the linting job as well

Please make it open for all, since it's a simple change for beginners. If no one does it in a week or so. I will make a PR against it

cc: @JyotinderSingh

bhima2001 commented 1 week ago

Hey I can take this up.

kitarp29 commented 1 week ago

I am not the maintainer or the repo, but I suggest you work on the changes. They should not take more than an hour (see the changes I made earlier).

apoorvyadav1111 commented 1 week ago

Hi @bhima2001 , Assigned. Thanks for contributing to DiceDB.

bhima2001 commented 1 week ago

@kitarp29 Hey, Is there any way I can test the workflow locally? Thanks

kitarp29 commented 1 week ago

Make a fork of this project on your account. On your clone:

Have the CI changes in main branch
Make a branch out of this branch. Make commits on that branch it would help you to test the changes in the fashion you wish to.

If satisfied make a PR with the main branch of your fork