#1029: json-numincrby-nummultby-toggle-forget-del migration and add integration testcases - Githubissues

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.86k stars 1.09k forks source link

#1029: json-numincrby-nummultby-toggle-forget-del migration and add integration testcases #1261

Closed vpsinghg closed 1 week ago

vpsinghg commented 2 weeks ago

This PR includes changes for migration of JSON.DEL, JSON.FORGET, JSON.TOGGLE, JSON,NUMINCRBY and JSON.NUMMULTBY command to new Eval method. This resolves issue #1029

Also introduces fix for oom err in resp protocol integration test on lower spec machines.

Improved Integration Test format.

Tasks Checklist

[x] Migrated the evalXXX function with the latest definition
[x] Update or add unit tests for the new implementation.
[x] All unit tests pass successfully.
[x] Ensure all integration tests pass successfully.

vpsinghg commented 2 weeks ago

@AshwinKul28 @ayadav16 @lucifercr07 make test all integration passing on local but failing in CI pipeline

apoorvyadav1111 commented 2 weeks ago

Hi @vpsinghg , Just to confirm, Have you rebased this with the latest master?

vpsinghg commented 2 weeks ago

Yes, No conflicts as I have created new branch and added my changes. Can anyone retrigger the pipeline?

apoorvyadav1111 commented 2 weeks ago

@vpsinghg , checks are okay now, I guess we just need to update some minor details and we are good to close this.

vpsinghg commented 2 weeks ago

@apoorvyadav1111 changes done. and check is also successful. Please go ahead

vpsinghg commented 1 week ago

@apoorvyadav1111 please review