search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.83k stars 1.08k forks source link

#761: Added ZADD options implementation - XX|NX|CH|INCR| LT|GT according to Redis source code #1262

Closed rushabhk04 closed 1 week ago

rushabhk04 commented 1 week ago

I have implemented Redis's option parsing for the ZADD command. Additionally, I wrote unit and integration test cases to cover the functionality.

@apoorvyadav1111 Please review this and let me know if any modifications are needed. Thank you!

I added the evaluated command logic, which handles ZADD based on option flags and operates according to the Redis source code. I also created the zset_test file for HTTP, web socket, and resp, which contains test cases for the command with various combinations of options.

Fixes #761 Closed PR related to the above https://github.com/DiceDB/dice/pull/1138 The existing open PR for this issue is https://github.com/DiceDB/dice/pull/1205 (the reason I have created a new PR is because of a messed up history in PR 1138).

Will put the documents in the other thread to net mess things up!

Thanks for understanding and assistance!

rushabhk04 commented 1 week ago

@JyotinderSingh Can you please review the PR, thanks

rushabhk04 commented 1 week ago

@JyotinderSingh , I have updated the changes. Can you please re-review it and merge it?

Also, please let me know if any questions or suggestions. Thanks