Add tests for `TYPE` command and add tests for all supported types

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.9k stars 1.1k forks source link

Add tests for `TYPE` command and add tests for all supported types #1340

Open arpitbbhayani opened 1 week ago

pankajjs commented 1 week ago

@arpitbbhayani @lucifercr07 Can I work on this ticket?

arpitbbhayani commented 6 days ago

@pankajjs go for it. Thanks for taking this up.

pankajjs commented 6 days ago

@arpitbbhayani We do have tests for TYPE command. However, It does not have support for few types.

https://github.com/DiceDB/dice/blob/master/integration_tests/commands/resp/type_test.go https://github.com/DiceDB/dice/blob/master/integration_tests/commands/http/type_test.go https://github.com/DiceDB/dice/blob/master/integration_tests/commands/websocket/type_test.go

lucifercr07 commented 1 day ago

@arpitbbhayani We do have tests for TYPE command. However, It does not have support for few types.

https://github.com/DiceDB/dice/blob/master/integration_tests/commands/resp/type_test.go https://github.com/DiceDB/dice/blob/master/integration_tests/commands/http/type_test.go https://github.com/DiceDB/dice/blob/master/integration_tests/commands/websocket/type_test.go

@pankajjs please add tests for missing types. Please let me know if you're facing any issue, we can sync up. Thanks for contributing.

pankajjs commented 15 hours ago

The type commands supports

these many data types. So, we need to add support for missing data types from this list only. Let me know if I understood the task correctly. @lucifercr07