search

DiceDB / dice

A drop-in replacement of Redis with SQL-based realtime reactivity.
https://dicedb-docs.netlify.app/
Other
3.16k stars 399 forks source link

Add support for `COMMAND` command #144

Open arpitbbhayani opened 1 month ago

arpitbbhayani commented 1 month ago

Add support for the COMMAND command in DiceDB similar to the COMMAND command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

kakdeykaushik commented 1 month ago

I would like to work on it. Can you please assign this issue to me ?

kakdeykaushik commented 1 month ago

created a draft PR https://github.com/DiceDB/dice/pull/158

maniSHarma7575 commented 1 month ago

@kakdeykaushik Are you still working on this? Or I can pick it up?

kakdeykaushik commented 1 month ago

@maniSHarma7575 i'm working on it

rohithputha commented 2 weeks ago

Hey @kakdeykaushik, are you still working on this or is it done?

kakdeykaushik commented 2 weeks ago

you can work on it @rohithputha

rohithputha commented 2 weeks ago

I would like to work on this, can this be assigned to me?

aashraybhandar1 commented 2 days ago

Hey @rohithputha are you working on it?

AshwinKul28 commented 2 days ago

@rohithputha thanks for picking this up. Can you please add any latest updates on this? Let us know if you have any blockers on this we can discuss this over the discord. if user is inactive and @aashraybhandar1 wants to work on it, we can assign it.

cc @JyotinderSingh

rohithputha commented 2 days ago

Hey. I am currently not working on this. you can assign this to @aashraybhandar1 cc @AshwinKul28 @JyotinderSingh

JyotinderSingh commented 2 days ago

Hey @rohithputha are you working on it?

Assigned to you.