#149 : Add list command for dicedb

DiceDB / dice

DiceDB is hyper-optimized for building and scaling truly real-time applications on modern hardware. It is a drop-in replacement for Redis with support for SQL-based reactivity.

https://dicedb.io/

Other

3.32k stars 420 forks source link

#149 : Add list command for dicedb #150

Closed yashs360 closed 1 month ago

yashs360 commented 1 month ago

Added list command. Please review and provide your inputs.

Summary of change:

Added Constants for Command names to keep it easy to add new commands, as well as reuse commands in tests
Added List command
Added test and benchmark

Benchmark results - (first time running benchmark so i don't have a baseline to compare if this code was good or shit). I could use some help here.

yashs360 commented 1 month ago

@arpitbbhayani @JyotinderSingh - First real code contribution, not like the past fluffy PRs. Please review.

JyotinderSingh commented 1 month ago

Thanks for this contribution!

JyotinderSingh commented 1 month ago

I re-read the associated issue, turns out the actual command name needs to be COMMAND LIST, and we should also include a memory benchmark. Let's do that before we merge this.