Closed Dev79844 closed 1 month ago
Hey @JyotinderSingh! I have done the changes and added the screenshots of benchmarks for RegexMatch and WildCardMatch in PR description. Kindly have a look at it.
Hey @JyotinderSingh! I have done the changes and added the screenshots of benchmarks for RegexMatch and WildCardMatch in PR description. Kindly have a look at it.
This is an amazing performance improvement! I think we can remove the old regex matching code (and related test/benchmark) altogether. The PR should be ready to merge after that.
Hey @JyotinderSingh! RegexMatch is also being used in WatchKeys function in async_tcp.go file. I don't think I can remove it unless I replace the RegexMatch with WildCardMatch in WatchKeys function too.
Hey @JyotinderSingh!
RegexMatch is also being used in WatchKeys function in async_tcp.go file. I don't think I can remove it unless I replace the RegexMatch with WildCardMatch in WatchKeys function too.
Even that can make use of the new wildcard function. All present usages of this method have the same purpose - to find keys that match a given wildcard pattern
Please rebase your PR on the latest master, there are merge conflicts.
Resolved the merge conflict
Thank you for the contribution!
Issue: #167
Summary:
Added wildcard matching for DSQL queries.
Changes:
Test
Benchmark test
RegexMatch
WildCardMatch