search

DiceDB / dice

DiceDB is hyper-optimized for building and scaling truly real-time applications on modern hardware. It is a drop-in replacement for Redis with support for SQL-based reactivity.
https://dicedb.io/
Other
3.32k stars 420 forks source link

Add support for Basic Auth #179

Closed gauravsarma1992 closed 1 month ago

gauravsarma1992 commented 1 month ago

https://github.com/DiceDB/dice/issues/141

Prior to Redis 6, authentication for a connection was enabled by passing in requirepass in the redis.conf or while starting the redis server. If the above config is set, prior to any command, the authentication has to be by running the following command:

AUTH '<password>'

Screenshot 2024-08-03 at 10 21 05 PM

requirepass can be set in the config by changing config/main.go before running the server.

The storage of user credentials and ACLs will be implemented in the subsequent PRs.

JyotinderSingh commented 1 month ago

Hi @gauravsarma1992, thanks for this contribution. Could you please rebase this PR on master and resolve the conflicts? Will review once done.

gauravsarma1992 commented 1 month ago

Hi @gauravsarma1992, thanks for this contribution. Could you please rebase this PR on master and resolve the conflicts? Will review once done.

Rebased the PR from the latest master.

JyotinderSingh commented 1 month ago

Please mark the PR ready for review once you are done with it.

gauravsarma1992 commented 1 month ago

@JyotinderSingh Please review

gauravsarma1992 commented 1 month ago

@arpitbbhayani Addressed the review comments. Please review again.

gauravsarma1992 commented 1 month ago

@JyotinderSingh Please review

arpitbbhayani commented 1 month ago

Changes look good. Thanks :) merging them.