search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.87k stars 1.09k forks source link

Add support for `PFDEBUG` command #240

Open Vsareen0 opened 3 months ago

Vsareen0 commented 3 months ago

Add support for the PFDEBUG command in DiceDB similar to the PFDEBUG command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

AshwinKul28 commented 3 months ago

Hey @Vsareen0 Do you have any updates on this? If you have any blockers lets discuss this over the discord. Or if you have multiple items on the plate, lets open this issue for everyone, and others can pick this up. Thanks

cc - @JyotinderSingh

chettriyuvraj commented 2 months ago

Would like to pick this up if possible

AshwinKul28 commented 2 months ago

@chettriyuvraj Assigned https://github.com/DiceDB/dice/issues/242 to you, this can be picked up by someone else. thank you.

deep-adeshraa commented 2 months ago

@AshwinKul28 If this is pending I would like to work on it.

ankkyprasad commented 2 months ago

Hi, I'd like to work on this issue.

AshwinKul28 commented 2 months ago

@deep-adeshraa over to you! Thanks for picking up.

deep-adeshraa commented 2 months ago

Thank you @AshwinKul28 - I started looking into it

neverwannafly commented 1 month ago

Please assign this issue to me. Thanks :)

JyotinderSingh commented 1 month ago

Please assign this issue to me. Thanks :)

Assigned

neverwannafly commented 1 month ago

Will close by this week.

arpitbbhayani commented 1 month ago

Hello @neverwannafly,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

benbarten commented 1 month ago

Hey @JyotinderSingh @arpitbbhayani @AshwinKul28,

if this still needs to be worked on, I'd like to pick it up. Thank you :)

neverwannafly commented 4 weeks ago

I have mostly completed it. One sub-command for PFDEBUG needs to be integrated. Will do this by this month. I'll raise a first draft PR by morrow

neverwannafly commented 4 weeks ago

Link to work in progress PR - https://github.com/DiceDB/dice/pull/1216/files @arpitbbhayani

neverwannafly commented 3 weeks ago

redis's hyperloglog implementation is slightly different from the lib we're using for go for the PFDEBUG subcommands decode, they return a run length encoding of their sparse data structure (for efficient representation). Our DS for sparseset is slightly different and wont make sense to return the exact same output (we make use of tempset and sparseset to lazily load/assign sparse fields). Would it be better to return a base64 encoded version and in our documentation provide end users how to unmarhsal it?