search

DiceDB / dice

DiceDB is an in-memory real-time database with SQL-based reactivity. It is hyper-optimized for building and scaling truly real-time applications on modern hardware while being a drop-in replacement for Redis.
https://dicedb.io/
Other
3.96k stars 492 forks source link

Report inconsistency in the command `JSON.GET` #380

Open arpitbbhayani opened 3 weeks ago

arpitbbhayani commented 3 weeks ago

This issue is all about ensuring we are as close to Redis as possible. The command in focus for this issue is JSON.GET.

Go through the official documentation of the command JSON.GET on Redis and identify the inconsistencies. The inconsistencies could be in

  1. unhandled edge case
  2. unexpected behavior
  3. unsupported option

Because we are trying to be compatible with Redis v7.2.5, I would recommend you try out different variants of the command with different inputs on that specific version. The instructions on running Redis v7.2.5 locally

Once you find the discrepancy, you can either

  1. raise an issue on Dice repository with details, or
  2. try to fix it yourself and raise a PR

If you are raising the issue, make sure you provide the details such as

  1. use the template and provide the following details
  2. steps to reproduce (series of commands)
  3. observed output on DiceDB
  4. observed output on Redis v7.2.5

Also, feel free to update the documentation and raise the PR in the docs repository.

You will need to go deeper into the command make sure you are covering all cases and reporting the inconsistencies or fixing them. The deeper the work, the better our stability will be. Also, it is possible that we do not find any discrepancies, so please mention the same in the comment on this issue. Mention the PR or issue links that you create under this issue.

sridhar-5 commented 3 weeks ago

@arpitbbhayani can I give this a shot?

arpitbbhayani commented 3 weeks ago

@sridhar-5 Go for it :)

AshwinKul28 commented 1 week ago

@sridhar-5 Hope you are doing well. Any updates on this?

sridhar-5 commented 5 days ago

Hey @AshwinKul28 , Apologies. wasn't able to get to this in the last few weeks (was pretty occupied). please feel free to delegate it to someone else if this is urgent. I'm planning to give it a shot in the next 2 days.

Lockps commented 11 hours ago

can i get this work?