search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.86k stars 1.09k forks source link

Report inconsistency in the command `JSON.GET` #380

Open arpitbbhayani opened 3 months ago

arpitbbhayani commented 3 months ago

This issue is all about ensuring we are as close to Redis as possible. The command in focus for this issue is JSON.GET.

Go through the official documentation of the command JSON.GET on Redis and identify the inconsistencies. The inconsistencies could be in

  1. unhandled edge case
  2. unexpected behavior
  3. unsupported option

Because we are trying to be compatible with Redis v7.2.5, I would recommend you try out different variants of the command with different inputs on that specific version. The instructions on running Redis v7.2.5 locally

Once you find the discrepancy, you can either

  1. raise an issue on Dice repository with details, or
  2. try to fix it yourself and raise a PR

If you are raising the issue, make sure you provide the details such as

  1. use the template and provide the following details
  2. steps to reproduce (series of commands)
  3. observed output on DiceDB
  4. observed output on Redis v7.2.5

Also, feel free to update the documentation and raise the PR in the docs repository.

You will need to go deeper into the command make sure you are covering all cases and reporting the inconsistencies or fixing them. The deeper the work, the better our stability will be. Also, it is possible that we do not find any discrepancies, so please mention the same in the comment on this issue. Mention the PR or issue links that you create under this issue.

sridhar-5 commented 3 months ago

@arpitbbhayani can I give this a shot?

arpitbbhayani commented 3 months ago

@sridhar-5 Go for it :)

AshwinKul28 commented 2 months ago

@sridhar-5 Hope you are doing well. Any updates on this?

sridhar-5 commented 2 months ago

Hey @AshwinKul28 , Apologies. wasn't able to get to this in the last few weeks (was pretty occupied). please feel free to delegate it to someone else if this is urgent. I'm planning to give it a shot in the next 2 days.

Lockps commented 2 months ago

can i get this work?

JyotinderSingh commented 2 months ago

can i get this work?

Assigned

psrvere commented 2 months ago

@JyotinderSingh - since I did some work on this issue while implementing JSON.DEBUG, let me know I can be of any help here.

Here is link of inconsistency analysis doc - https://docs.google.com/spreadsheets/d/1cvgVa5fzs5hfDaPBNFHcXS_YFixiqiuzkE97cDgpqXA/edit?usp=sharing

JyotinderSingh commented 2 months ago

@JyotinderSingh - since I did some work on this issue while implementing JSON.DEBUG, let me know I can be of any help here.

Here is link of inconsistency analysis doc - https://docs.google.com/spreadsheets/d/1cvgVa5fzs5hfDaPBNFHcXS_YFixiqiuzkE97cDgpqXA/edit?usp=sharing

You can help review the PR which @Lockps will be raising. It will be a big help!

arpitbbhayani commented 2 months ago

Hello @Lockps,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Lockps commented 2 months ago

Thank you for your patience, I’m currently working on the JSON object response and will commit the finished work as soon as possible. I appreciate your understanding and will prioritize this issue.

If I encounter any challenges, I’ll reach out for assistance. Thanks for your support!

arpitbbhayani commented 1 month ago

Hello @Lockps,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Lockps commented 1 month ago

It will be done in 2-3 days!

Thanks for waiting

arpitbbhayani commented 1 month ago

Hello @Lockps,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Lockps commented 1 month ago

Hi @arpitbbhayani ,

Upon reviewing, I noticed that issue #1002 aligns with the work I have been doing. I believe this issue can be closed. Apologies for the delayed notice, as I initially thought it was a simple matter, but I now realize it's more complex than I expected.

shashank-priyadarshi commented 1 month ago

@arpitbbhayani @JyotinderSingh I would like to take this up if this is still a valid issue.

shashank-priyadarshi commented 1 month ago

Following up @arpitbbhayani @JyotinderSingh 🙂!

JyotinderSingh commented 1 month ago

Following up @arpitbbhayani @JyotinderSingh 🙂!

Assigned