Closed AshwinKul28 closed 1 month ago
Hi is it okay if I give this a try?
Sure @sbshah97 Thanks for picking it up!
@JyotinderSingh please assign it to him.
Hi is it okay if I give this a try?
Assigned
Hi I'm going to be looking at this on Tuesday. Slightly caught up on the weekend.
Running tool: /opt/homebrew/bin/go test -benchmem -run=^$ -bench ^BenchmarkEvalMSET$ github.com/dicedb/dice/core
goos: darwin
goarch: arm64
pkg: github.com/dicedb/dice/core
BenchmarkEvalMSET-10 50248 22360 ns/op 328741 B/op 24 allocs/op
PASS
ok github.com/dicedb/dice/core 1.615s
Fixed this and tested on local running only the test. Earlier it was not running, runs now based on the above hints. Sending MR now.
How to reproduce?
The test suite forever halts at this point. There's an issue in the
BenchmarkEvalMSET
(If you comment this particular test whole suite runs perfectly fine) Get the debug logs while benchmarking -GODEBUG=gctrace=1 go test -bench=. -test.benchmem
Probable issue:
It seems in each iteration, the store and required values are not getting initialized causing blockage