Flushing store data to temp file in BGREWRITEAOF command and use fsync

DiceDB / dice

DiceDB is a redis-compliant, in-memory, real-time, and reactive database optimized for modern hardware and for building and scaling truly real-time applications.

https://dicedb.io/

Other

6.65k stars 1.06k forks source link

Flushing store data to temp file in BGREWRITEAOF command and use fsync #398

Closed ashwaniYDV closed 2 months ago

ashwaniYDV commented 2 months ago

closes https://github.com/DiceDB/dice/issues/397 https://github.com/DiceDB/dice/issues/17

ashwaniYDV commented 2 months ago

@yashs360 @JyotinderSingh please review this PR. This would guarantee that the old AOF file is not corrupted when some error occurs in BGREWRITEAOF and would improve durability.

ashwaniYDV commented 2 months ago

@arpitbbhayani would you please review

amityahav commented 2 months ago

@JyotinderSingh Please wait with that. I have a pr that makes this even more robust and correct see: https://github.com/DiceDB/dice/pull/401

ashwaniYDV commented 2 months ago

closing this PR. thanks @amityahav