search

DiceDB / dice

DiceDB is a redis-compliant, in-memory, real-time, and reactive database optimized for modern hardware and for building and scaling truly real-time applications.
https://dicedb.io/
Other
6.67k stars 1.06k forks source link

Add support for command `JSON.ARRINSERT` #487

Closed arpitbbhayani closed 1 month ago

arpitbbhayani commented 1 month ago

Add support for the JSON.ARRINSERT command in DiceDB similar to the JSON.ARRINSERT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

JyotinderSingh commented 1 month ago

@jujiale since you've extensively helped support JSON features in DiceDB so far, would you like to take this issue up?

jujiale commented 1 month ago

@jujiale since you've extensively helped support JSON features in DiceDB so far, would you like to take this issue up?

sure.please assgin to me. thanks.

ar1fKhan commented 1 month ago

Hello @lucifercr07 & @jujiale , Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

jujiale commented 1 month ago

Hello @lucifercr07 & @jujiale , Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

yes. processing.