search

DiceDB / dice

DiceDB is a redis-compliant, in-memory, real-time, and reactive database optimized for modern hardware and for building and scaling truly real-time applications.
https://dicedb.io/
Other
6.67k stars 1.06k forks source link

Add support for command `JSON.NUMINCRBY` #496

Closed arpitbbhayani closed 1 month ago

arpitbbhayani commented 1 month ago

Add support for the JSON.NUMINCRBY command in DiceDB similar to the JSON.NUMINCRBY command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

apoorvyadav1111 commented 1 month ago

Please assign this to me.

lucifercr07 commented 1 month ago

@apoorvyadav1111 assigned, thanks for picking this up.