search

DiceDB / dice

DiceDB is an in-memory real-time database with SQL-based reactivity. It is hyper-optimized for building and scaling truly real-time applications on modern hardware while being a drop-in replacement for Redis.
https://dicedb.io/
Other
4.18k stars 517 forks source link

Add support for command `JSON.NUMMULTBY` #497

Open arpitbbhayani opened 1 week ago

arpitbbhayani commented 1 week ago

Add support for the JSON.NUMMULTBY command in DiceDB similar to the JSON.NUMMULTBY command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

c-harish commented 1 week ago

@arpitbbhayani. Could you please assign this to me? I would like to work on it.

lucifercr07 commented 1 week ago

@c-harish assigned, thanks for picking this up.

jainbhavya53 commented 2 days ago

Hi @lucifercr07 @c-harish Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

jainbhavya53 commented 2 days ago

Also, this command has been deprecated here, do we still want to support it ? https://redis.io/docs/latest/commands/json.nummultby/

c-harish commented 2 days ago

Hi @lucifercr07 @c-harish Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

Hi @jainbhavya53. I am done with the eval func and yet to complete the unit tests. I will raise PR before tomorrow.