search

DiceDB / dice

DiceDB is a redis-compliant, in-memory, real-time, and reactive database optimized for modern hardware and for building and scaling truly real-time applications.
https://dicedb.io/
Other
6.67k stars 1.06k forks source link

Add support for command `JSON.OBJLEN` #499

Closed arpitbbhayani closed 1 month ago

arpitbbhayani commented 1 month ago

Add support for the JSON.OBJLEN command in DiceDB similar to the JSON.OBJLEN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

rushabhk04 commented 1 month ago

Assign this issue to me. Thanks

lucifercr07 commented 1 month ago

@rushabhk04 assigned, thanks for picking this up.

iamskp11 commented 1 month ago

Hey @lucifercr07 @rushabhk04 , Since there are no updates here since 5 days, is this still being worked on? Will be happy to work on this

rushabhk04 commented 1 month ago

Yes, please go ahead with it. Thanks

iamskp11 commented 1 month ago

Hey @lucifercr07 , have picked this one, and have done basic method implementation. Will be sharing PR post tests and benchmarking memory + time. Thanks!

phaneesh707 commented 1 month ago

Hey @iamskp11 , i'm really sorry didn't notice that you are also working on it , since this issue was inactive i just started working on and created a PR for it.Sorry! @lucifercr07 could you please review the PR,thanks.