search

DiceDB / dice

DiceDB is a redis-compliant, in-memory, real-time, and reactive database optimized for modern hardware and for building and scaling truly real-time applications.
https://dicedb.io/
Other
6.67k stars 1.06k forks source link

Add support for command `JSON.STRAPPEND` #501

Closed arpitbbhayani closed 3 weeks ago

arpitbbhayani commented 1 month ago

Add support for the JSON.STRAPPEND command in DiceDB similar to the JSON.STRAPPEND command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

rishu1601 commented 1 month ago

@arpitbbhayani - Can you please assign this to me? I am new to the dicedb world, looking forward to tackle this

lucifercr07 commented 1 month ago

@rishu1601 assigned, thanks for picking this up.

jainbhavya53 commented 1 month ago

Hi @lucifercr07 Is this still being worked upon ? Otherwise I'll be happy to pick this up. Thanks

lucifercr07 commented 1 month ago

@rishu1601 can you please share updates on the issue?

rishu1601 commented 1 month ago

I will be picking this up and complete it this weekend

On Mon, Sep 16, 2024, 10:11 Prashant Shubham @.***> wrote:

@rishu1601 https://github.com/rishu1601 can you please share updates on the issue?

— Reply to this email directly, view it on GitHub https://github.com/DiceDB/dice/issues/501#issuecomment-2352008824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIFSFQQZQU3UE6WMYRHSQTZWZON3AVCNFSM6AAAAABN3HCKACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSGAYDQOBSGQ . You are receiving this because you were mentioned.Message ID: @.***>

karandixit10 commented 1 month ago

Hi @lucifercr07 Can I pick this up if no one working on it?

lucifercr07 commented 1 month ago

@karandixit10 will assign on Monday if no updates by then.

psrvere commented 1 month ago

@lucifercr07 - I can pick this up if it's available.

lucifercr07 commented 1 month ago

@psrvere will assign this to @karandixit10 for now as he had already asked earlier. For upcoming issues will try to assign.

karandixit10 commented 1 month ago

@lucifercr07 will start this from tomorrow, I'll try to complete it by tomorrow.

karandixit10 commented 1 month ago

@lucifercr07 I have implemented this just need to add integration tests and unit tests for this

arpitbbhayani commented 1 month ago

Hello @karandixit10,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

karandixit10 commented 1 month ago

Hi @arpitbbhayani , I have already implemented this and it's already been reviewed in this PR #882 , Just waiting for it to get merge.

Thanks.

arpitbbhayani commented 3 weeks ago

Hello @karandixit10,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.