search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.76k stars 1.07k forks source link

Multi threading support for QWATCH #566

Open soumya-codes opened 2 months ago

soumya-codes commented 2 months ago

Ensure QWATCH implementation is able to handle notifications from multiple-shards.

kushal0511-not commented 2 months ago

@soumya-codes would like to work on this.

soumya-codes commented 2 months ago

@kushal0511-not sure, you can pick this up. cc @JyotinderSingh who is better placed in helping you with this.

arpitbbhayani commented 1 month ago

Hello @kushal0511-not,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

SyedMa3 commented 1 month ago

Hello @kushal0511-not,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Hey, I would like to take up the issue if it has to be reassigned. Already familiar with the codebase.

kushal0511-not commented 1 month ago

@arpitbbhayani @SyedMa3 as per discussed in call for multithreading on discord, QWATCH is last thing in multi-threading. so once multi-threading support is ready i will start this. currently integration of worker and eval is also remaining. Ref: https://github.com/DiceDB/dice/issues/568

kushal0511-not commented 1 month ago

@JyotinderSingh I’m currently occupied with other work commitments and won’t be able to work on this. Feel free to assign yourself or someone else. Thanks.

SyedMa3 commented 1 month ago

@JyotinderSingh Can I work on this?

JyotinderSingh commented 1 month ago

@JyotinderSingh Can I work on this?

Thanks for volunteering @SyedMa3. However I will be taking this up for now, since I have bit more experience with developing this feature.

arpitbbhayani commented 1 month ago

Hello @JyotinderSingh,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani commented 1 month ago

Hello @JyotinderSingh,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

psrvere commented 3 weeks ago

@JyotinderSingh - please assign this to me.

psrvere commented 1 week ago

I will start working on this from tomorrow.