search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.78k stars 1.07k forks source link

A Better CI #620

Open kitarp29 opened 1 month ago

kitarp29 commented 1 month ago

I think there are 3 things I can add to the CI pipeline to improve it.

  1. Cache: We could cache the go pkg and docker layers. It will improve the speed of the pipelines. Also not hit the DockerHub limit (ar fetched yet better to have)
  2. CVE Scans: We could implement a CVE scan for free with a tool like Trivy. Not fail pipelines but to be aware of the CVEs in case. This can be done using inbuilt GitHub features or even Snyk free version
  3. Image Scan: Well this is the last thing to do. However, scanning DockerImages is a good option in the long run. Github has tools, Trivy has free plans, and even Docker has Docker Scout

Also for the issues we can Github bots that check for stale issues and take some load off the maintainers.

Let me know if I can take this up @JyotinderSingh

JyotinderSingh commented 1 month ago

Thanks for taking this up @kitarp29. Assigned to you.

kitarp29 commented 1 month ago

Thanks Man! But sadly my laptop is in the shop, my baby is getting old :( I will work in it after 7th Oct

arpitbbhayani commented 1 month ago

Hello @kitarp29,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

kitarp29 commented 1 month ago

Hey Arpit Sorry for the late reply. My laptop has been in the shop for a while. I will try to work on it tonight if someone is not working on it. I will try to give you a working PR within the next few days

On Wed, 9 Oct 2024 at 08:04, Arpit Bhayani @.***> wrote:

Hello @kitarp29 https://github.com/kitarp29,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

— Reply to this email directly, view it on GitHub https://github.com/DiceDB/dice/issues/620#issuecomment-2401151133, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANRGAFLW3ANJZWMK36Y2TADZ2SI25AVCNFSM6AAAAABOQFJRVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGE2TCMJTGM . You are receiving this because you were mentioned.Message ID: @.***>

arpitbbhayani commented 3 weeks ago

Hello @kitarp29,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

kitarp29 commented 3 weeks ago

Hi @arpitbbhayani I already have a MR up

There are things to discuss with your team to finalise the structure.