search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.76k stars 1.07k forks source link

Add support for command `HDEL` #645

Closed arpitbbhayani closed 1 month ago

arpitbbhayani commented 1 month ago

Add support for the HDEL command in DiceDB similar to the HDEL command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

HassanAarzoo commented 1 month ago

Please assign this to me

arpitbbhayani commented 1 month ago

@HassanAarzoo you have another one assigned to you. I will keep this one open for someone else to pick. Thanks for understanding.

anchalsinghrajput commented 1 month ago

Hi Arpit, can i work on this issue?

HassanAarzoo commented 1 month ago

@arpitbbhayani Yes its fine! Thank You

meetghodasara commented 1 month ago

Hi @arpitbbhayani , can I work on this issue?

karandixit10 commented 1 month ago

Hi @arpitbbhayani, I can take this up if no one's working on it yet?

manishrw commented 1 month ago

Hi @arpitbbhayani, Please assign this issue to me. I've addressed the issue in the PR #678

arpitbbhayani commented 1 month ago

Hello @manishrw,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

manishrw commented 1 month ago

Hey @arpitbbhayani, the PR which adds command HDEL has already been merged. #678

manishrw commented 1 month ago

Hey @arpitbbhayani @lucifercr07! Does this need something more to be closed? We've already added the command HSCAN with tests.

lucifercr07 commented 1 month ago

Closing, merged as part of https://github.com/DiceDB/dice/issues/645