Http Integration Tests: Create tests to support HTTP(7)

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.89k stars 1.1k forks source link

Http Integration Tests: Create tests to support HTTP(7) #740

Closed pratikpandey21 closed 1 month ago

pratikpandey21 commented 2 months ago

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

hsetnx_test.go
hstrlen_test.go
hyperloglog_test.go
incr_by_float_test.go
incr_test.go

Steps: 1) Create the corresponding tests for these commands in integration_tests/commands/http. 2) Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP. 3) Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

hgupta12 commented 2 months ago

@pratikpandey21 can I take this up?

lucifercr07 commented 2 months ago

@hgupta12 assigned, thanks for contributing.

arpitbbhayani commented 2 months ago

Hello @hgupta12,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

hgupta12 commented 2 months ago

Hey @arpitbbhayani , I have already opened a PR #873 to resolve this issue. I am done with implementing all the tests. There are a few errors which need to be resolved and I am working on them right now.