search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.87k stars 1.09k forks source link

Add support for Count Min Sketch #992

Closed hgupta12 closed 1 month ago

hgupta12 commented 1 month ago

DiceDB currently doesn't support the Count Min Sketch data structure. I would like to add CMS.INITBYDIM, CMS.INITBYPROB, CMS.INCRBY, CMS.QUERY, CMS.MERGE, CMS.INFO commands.

I have started looking at the theory and some available implementations.

hgupta12 commented 1 month ago

@lucifercr07 @JyotinderSingh kindly assign this issue to me.

arpitbbhayani commented 1 month ago

Hello @hgupta12,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

hgupta12 commented 1 month ago

Hey @arpitbbhayani since this was a big addition it took me a while. I had implemented the commands for the old async server but had to migrate them to the resp server in the same PR making it take longer. The PR is ready for review now.