search

DiceHard / n20-android

Natural20 Android Application
1 stars 1 forks source link

Spinner Offset -> default offset #3

Closed IanDCarroll closed 8 years ago

IanDCarroll commented 8 years ago

As a user, I need the option to ignore which side is facing up and just hit the roll button to get a die roll so that I don't have to think, I can still just roll. Whatever the results of the last die roll needs to be the default value of the spinner. If it's the first roll, it is set to a random number on the die.

davidlarrimore commented 8 years ago

Hey @IanDCarroll, Please review. Added to commit 269b915

IanDCarroll commented 8 years ago

I think I get how you did it. At a glance it looks sound.

I was thinking we might want a test to see if it's really doing it, but when we add the display features, that'll be a pretty good indicator.

davidlarrimore commented 8 years ago

Probably some debug logging. I can set that up tonight

Thanks, David Larrimore

On Jul 21, 2016, at 4:16 AM, Ian Carroll notifications@github.com wrote:

I think I get how you did it. At a glance it looks sound. Is there a surefire way we can test to make sure it's offsetting the result by the value of the last roll?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.