search

DiceTechnology / dice-where

IP to Location lookup library
MIT License
3 stars 0 forks source link

Fix/md5 management #108

Closed gedl closed 3 months ago

gedl commented 5 months ago

This PR aims to:

1 - replace user defined metadata by S3's etag for md5 matching 2 - Improve md5 logging 3 - Reject the destination file if md5 mismatches

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 48.64865% with 19 lines in your changes missing coverage. Please review.

Project coverage is 58.78%. Comparing base (b2e6e1b) to head (88784f8).

Files Patch % Lines
...technology/dice/dicewhere/downloader/Download.java 0.00% 11 Missing :warning:
.../dice/dicewhere/downloader/source/s3/S3Source.java 0.00% 4 Missing :warning:
...ownloader/destination/local/LocalFileAcceptor.java 50.00% 1 Missing and 1 partial :warning:
...here/downloader/destination/s3/S3FileAcceptor.java 88.23% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #108 +/- ## ============================================= - Coverage 72.64% 58.78% -13.86% - Complexity 338 370 +32 ============================================= Files 65 97 +32 Lines 1378 1912 +534 Branches 147 167 +20 ============================================= + Hits 1001 1124 +123 - Misses 323 729 +406 - Partials 54 59 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.