search

Dicebar / Raven

Raven add-on for World of Warcraft
9 stars 3 forks source link

Arms Warrior Ignore Pain and Shield Block. #39

Closed DakHarding closed 1 year ago

DakHarding commented 1 year ago 
          Hello again, on retail with Arms Warrior, still running into intermittent issues again with cooldowns showing available while still counting down. Sometimes 4-5 seconds out. Specifically Ignore Pain and Shield Block.

Also, attached a pic and the following Shield Block conditional doesn't seem to work even though all criteria are true. Thanks. ShieldBlockBug

Originally posted by @DakHarding in https://github.com/Dicebar/Raven/issues/36#issuecomment-1461274598

Dicebar commented 1 year ago

Thanks, I'll have a look!

Dicebar commented 1 year ago

I've created a patch for the bugs that caused these issues.

The Shield Block one was actually caused by the cooldown cache incorrectly overwriting the cooldown of the ability "Shield Block" with the Protection rank-up that gives Shield Block two charges. That passive ability is also called "Shield Block", which obviously has no cooldown to test for and is never a usable ability.

Anyway, a new release should be on its way through the CurseForge pipelines at the moment.