search

Dicebar / Raven

Raven add-on for World of Warcraft
9 stars 3 forks source link

Changes for 10.2.6 Deprecated API calls #68

Closed arnvid closed 5 months ago

Dicebar commented 5 months ago

Thanks for the fixes, I really appreciate it 😊

Blizzard made these changes NextLevelHard™️ by including the new namespace change in both Classic and in Retail, but not in Wrath. Effectively ending the presumption that if something works in Classic it will also work in Wrath...

Once I've updated the codebase to work for Wrath too, I'll release these updates to the wild.

arnvid commented 5 months ago

@Dicebar - another sneaky change they did now was to split Deprecated into multiple pieces.

RequiredDeps: Blizzard_Deprecated, Blizzard_DeprecatedCurrencyScript, Blizzard_DeprecatedGuildScript, Blizzard_DeprecatedItemScript, Blizzard_DeprecatedPvpScript, Blizzard_DeprecatedSoundScript, Blizzard_DeprecatedSpellScript

Dicebar commented 5 months ago

I don't think we rely on that (thankfully?), but it's good to know about.

Blizzard actually managed to introduce three different ways to call GetItemCooldown(); one for Classic, Wrath and Retail each 🤦‍♂️

I just moved all these mismatched namespaced functions to a single file (Shims.lua), which seems to cover all of the exceptions and hopefully will make the codebase more resilient to future similar changes.

All of these changes (including your PR) is in the r651 release, which is deploying now.