search

Dich0tomy / oxocarbon-lua.nvim

A lua rewrite of the original oxocarbon theme.
MIT License
81 stars 12 forks source link

Fix telescope support #4

Closed ysomad closed 2 years ago

ysomad commented 2 years ago

Is it just me or telescope with oxocarbon looks kinda bad?

Dich0tomy commented 2 years ago

@ysomad what kind of changes do you expect? Generally the original colorscheme seems lacking a lot of things and seems like it's made specifically for the author, I'm thinking of rewriting it and making it more complete and configurable, tho that's some work and I don't really have that much time everyday.

ysomad commented 2 years ago

@ysomad what kind of changes do you expect? Generally the original colorscheme seems lacking a lot of things and seems like it's made specifically for the author, I'm thinking of rewriting it and making it more complete and configurable, tho that's some work and I don't really have that much time everyday.

Seems like it's lacking borders in telescope windows and some colors looks odd atleast it looks like it for me.

How it looks in oxocarbon image

Gruvbox for example image

Dich0tomy commented 2 years ago

@ysomad I see. I'll look into how telescope higlight groups work today night or tommorow.

Dich0tomy commented 2 years ago

@ysomad Hey. With the new changes you are able to do

vim.g.oxocarbon_lua_alternative_telescope = true

To change the telescope's theming.

Try it and tell me how it feels! Cheers.

ysomad commented 2 years ago

@ysomad Hey. With the new changes you are able to do

vim.g.oxocarbon_lua_alternative_telescope = true

To change the telescope's theming.

Try it and tell me how it feels! Cheers.

I set global variable you've provided and updated plugin but it does not work :( Telescope still the same even with true option. image

Dich0tomy commented 2 years ago

@ysomad are you sure you updated the plugin? Also, I'm pretty sure the option should be set before the plugin loads.

ysomad commented 2 years ago

@ysomad are you sure you updated the plugin? Also, I'm pretty sure the option should be set before the plugin loads.

Yes, I updated with PackerSync and options.lua module is loading before plugins in my configuration image

ysomad commented 2 years ago

@ysomad are you sure you updated the plugin? Also, I'm pretty sure the option should be set before the plugin loads.

I got it, if I set the variable before setting colorscheme it works!

ysomad commented 2 years ago

I love it! Thank you so much! I think you can close the issue.

Dich0tomy commented 2 years ago

@ysomad awesome, no problem.