Dich0tomy / oxocarbon-lua.nvim

A lua rewrite of the original oxocarbon theme.
MIT License
81 stars 12 forks source link

Add support for lualine? #5

Open nexxeln opened 1 year ago

nexxeln commented 1 year ago

lualine.nvim is a popular neovim status line plugin which has support for various themes, but doesn't really work with oxocarbon. After having used oxocarbon for a few weeks now I can't go back to any other theme so I would love to have oxocarbon as a theme for lualine.

I opened this issue in the original repo too but didn't get a reply, this fork seems like it has more features too! Great work

Looks kind of plain right now

screenshot of lualine

Dich0tomy commented 1 year ago

Hey. I can sure do something about it. Can you please post some screenshots of other themes and how they look with lualine? I personally don't use lualine so I want to use what balance of colors looks and works the best. Thanks.

nexxeln commented 1 year ago

Hi! Thanks for the quick response! Here's how it looked in the my old theme (solarazied dark). It's a bit hard to see you'll have to zoom in

lualine in solarized dark

There are some more screenshots on the lualine repo as well.

Dich0tomy commented 1 year ago

Thanks. I'll probably do a few different versions, just not now. If I will not respond again in 2 days, please ping me.

nexxeln commented 1 year ago

Sure thing

nexxeln commented 1 year ago

Its been 2 days, just reminding you @B4mbus

Dich0tomy commented 1 year ago

@nexxeln Hey. Can you install oxocarbon from the lualine branch, set the theme and tell me how it looks? I don't have lualine set up so I wasn't able see if it even works. Thanks. image With packer that would be

use {
  'B4mbus/oxocarbon-lua.nvim',
  branch = 'lualine'
}

I believe.

nexxeln commented 1 year ago

Hey! I installed it and used the instructions from the readme to set the global options. I tried both 1 and 2. But I think the number is being compared to a boolean somewhere in the code. Here's the error.

error

Dich0tomy commented 1 year ago

Oh crap, indeed. I pushed new changes, try again, please.

nexxeln commented 1 year ago

Works now, but its kind of unreadable?

screenshot screenshot

Also doesn't match the theme a whole lot

nexxeln commented 1 year ago

Sorry if I'm being too demanding 😄

Dich0tomy commented 1 year ago

@nexxeln oh I see. You're not too demanding at all, you are the user, you have all the rights to demand :p

I'll install lualine and fiddle around to make something sensible, It will probably all come down to a single theme tho.

nexxeln commented 1 year ago

That sounds good to me!