search

DickinsonCollege / FD2School-FarmData2-S23

A fork of FarmData2 that is used for the FarmData2 School Activities.
Other
1 stars 36 forks source link

FieldKit Tab: Test for FieldKit Sub-Tabs #212

Closed JinLeeGG closed 1 year ago

JinLeeGG commented 1 year ago

Pull Request Description

addresses #200

Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

johnmaccormick commented 1 year ago

@JinLeeGG @Shahir-47 @won369369 -- Please check with Professor Braught about the file name for this test. I'm not sure if your choice is correct or not.

johnmaccormick commented 1 year ago

For subtask 1, I'm not convinced it's a good idea to rely on ".pagination-sm" as the identifier for the sub tabs. My instinct is that we should be looking for something that is more intuitively and uniquely associated with the sub tabs themselves.

Then I think I would also look for something more specific and uniquely associated with the element containing the text "Info".

Similarly for the other sub tab.

Try to apply the same kind of improvements to the other subtasks. Once you think you have a good approach, mark your PR ready for review again. Feel free to ask questions in the meantime.

We should also check with Professor Braught since I'm not completely confident in my suggestions, but I think this is a useful piece of learning for us.

johnmaccormick commented 1 year ago

By the way, I am experimenting with different workflows as I learn the techniques of being a reviewer/maintainer on GitHub. One thing that I just tried was downgrading your PR to a draft PR. I'm not sure if this should be part of the typical reviewer workflow or not, but I am trying it out. We can discuss whether this is a useful distinction or not.

johnmaccormick commented 1 year ago

looks good -- merged! nice work!